Skip to content

Allow option for visual output tab#165

Closed
conorriches wants to merge 3 commits into
mainfrom
tabs/change-default-tab
Closed

Allow option for visual output tab#165
conorriches wants to merge 3 commits into
mainfrom
tabs/change-default-tab

Conversation

@conorriches
Copy link
Copy Markdown
Contributor

@conorriches conorriches commented Aug 15, 2022

Greetings, humans.

On the Mission Zero editor page, where we use this editor, I noted that the editor defaults to text output. This might confuse users who may expect to see the build hat when adding in code.

Therefore I'm proposing this change which let's developers select whether they want the visual output tab.

Usage is this, e.g. <editor-wc visualOutput="1" .../>

image

@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-ui-pi-tabs-chang-j0jnz9 August 15, 2022 11:38 Inactive
@raspberrypigithubbot
Copy link
Copy Markdown

  • CircleCI build #713
  • Test coverage: 62%

@conorriches conorriches changed the title Set default output tab to be the visual editor Allow option for visual output tab Aug 15, 2022
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-ui-pi-tabs-chang-j0jnz9 August 15, 2022 15:43 Inactive
@raspberrypigithubbot
Copy link
Copy Markdown

  • CircleCI build #715
  • Test coverage: 61%

@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-ui-pi-tabs-chang-j0jnz9 August 15, 2022 15:55 Inactive
@raspberrypigithubbot
Copy link
Copy Markdown

  • CircleCI build #716
  • Test coverage: 62%

@conorriches conorriches marked this pull request as ready for review August 15, 2022 15:59
@patch0
Copy link
Copy Markdown
Contributor

patch0 commented Aug 22, 2022

I think this will be addressed by #173.

@patch0
Copy link
Copy Markdown
Contributor

patch0 commented Sep 1, 2022

I've closed this for now.

@patch0 patch0 closed this Sep 1, 2022
@patch0 patch0 deleted the tabs/change-default-tab branch March 27, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants